[lmi-commits] [lmi] master a6c035d 3/4: Expunge a useless conditional

[Greg Chicares]

branch: master
commit a6c035d39d2a71c819eba4ab29ccd97655301b5c
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Expunge a useless conditional
    
    It seems natural to suppose that 'ProducerCity' could be an empty
    string. However, it's actually the concatenation of several strings,
    one of which (Input::AgentState) can never be empty. At any rate,
    the removed conditional
      ProducerCity != "0"
    could never be true, because Input::AgentState is always two characters
    long, so a string containing it can never match a one-character string
    consisting of the numeral zero. (Probably something like "length != 0"
    was intended, but that could never be true, either.)
---
 ill_reg_header.mst | 4 +---
 pdf_command_wx.cpp | 5 -----
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/ill_reg_header.mst b/ill_reg_header.mst
index 198f81b..951db5a 100644
--- a/ill_reg_header.mst
+++ b/ill_reg_header.mst
@@ -33,9 +33,7 @@
     <br>{{InsCoName}}
     <br>Presented by: {{ProducerName}}
     <br>{{ProducerStreet}}
-    {{#HasProducerCity}}
-        <br>{{ProducerCity}}
-    {{/HasProducerCity}}
+    <br>{{ProducerCity}}
 </p>
 <p>
 </p>
diff --git a/pdf_command_wx.cpp b/pdf_command_wx.cpp
index f8b384c..7199b3e 100644
--- a/pdf_command_wx.cpp
+++ b/pdf_command_wx.cpp
@@ -2224,11 +2224,6 @@ class pdf_illustration_naic : public pdf_illustration
             }
 
         add_variable
-            ("HasProducerCity"
-            ,invar.ProducerCity != "0"
-            );
-
-        add_variable
             ("HasInterestDisclaimer"
             ,!invar.InterestDisclaimer.empty()
             );