lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master a9c5ed5 7/8: Resolve a marked defect [389]


From: Greg Chicares
Subject: [lmi-commits] [lmi] master a9c5ed5 7/8: Resolve a marked defect [389]
Date: Mon, 24 Apr 2017 16:43:51 -0400 (EDT)

branch: master
commit a9c5ed550ea9e9f49f3871c5267e8581922c5553
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Resolve a marked defect [389]
    
    The immediately-preceding commit message might explain why this test
    failed with como C++98.
---
 numeric_io_test.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/numeric_io_test.cpp b/numeric_io_test.cpp
index 5c4133f..413463f 100644
--- a/numeric_io_test.cpp
+++ b/numeric_io_test.cpp
@@ -139,7 +139,12 @@ int test_main(int, char*[])
     BOOST_TEST_EQUAL(16, floating_point_decimals(0.450359962737049596));
     BOOST_TEST_EQUAL(16, floating_point_decimals(0.4503599627370495));
     BOOST_TEST_EQUAL(16, floating_point_decimals(0.4503599627370496));
-    // TODO ?? Fails for como with mingw, but succeeds with 0.45036 .
+    // The following test failed for como with mingw (although with a
+    // value of 0.45036 it unsurprisingly succeeded). It was observed
+    // to fail also with x86_64-linux-gnu, but only because of a
+    // mistake that was found before committing, i.e., using log10()
+    // instead of std::log10() in the implementation caused C function
+    // log10(double) to be called instead of log10l().
     BOOST_TEST_EQUAL(15, floating_point_decimals(0.4503599627370497));
 
     BOOST_TEST_EQUAL(   "3.14", simplify_floating_point(    "3.14"));



reply via email to

[Prev in Thread] Current Thread [Next in Thread]