[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 7688b71 3/4: Clean up a midden
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 7688b71 3/4: Clean up a midden |
Date: |
Wed, 1 Mar 2017 05:57:11 -0500 (EST) |
branch: master
commit 7688b71d18b461bfc3e6cab3d61ea21beb1ca664
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Clean up a midden
The ancient commented-out lines herewith removed could only mislead.
They should have been expunged before the 2005-01-14 initial checkin.
// last_input_duration_ += current_duration_scalar_;
// last_input_duration_ = current_duration_scalar_;
No: only validate_duration() should set that.
// duration_mode trial_begin_mode = e_duration;
No: correct value really is previous_duration_scalar_mode_. The
interval ends at a given duration, but its begin_mode is determined
by the preceding interval's end_mode.
// int trial_end_duration = last_input_duration_ +\
current_duration_scalar_;
Plainly wrong: both addends are distance from the origin. It
wouldn't make sense to add them unless one of them were a delta.
---
input_sequence_parser.cpp | 4 ----
1 file changed, 4 deletions(-)
diff --git a/input_sequence_parser.cpp b/input_sequence_parser.cpp
index 9dc72c6..e3e567f 100644
--- a/input_sequence_parser.cpp
+++ b/input_sequence_parser.cpp
@@ -220,12 +220,8 @@ void SequenceParser::single_duration()
{
duration_scalar();
int trial_begin_duration = last_input_duration_;
-// last_input_duration_ += current_duration_scalar_;
-// last_input_duration_ = current_duration_scalar_;
-// duration_mode trial_begin_mode = e_duration;
duration_mode trial_begin_mode = previous_duration_scalar_mode_;
int trial_end_duration = current_duration_scalar_;
-// int trial_end_duration = last_input_duration_ + current_duration_scalar_;
duration_mode trial_end_mode = current_duration_scalar_mode_;
validate_duration
(trial_begin_duration