[lmi-commits] (no subject)

[Greg Chicares]

branch: master
commit 595b5f8b2ee0df1f0b25c29ee62455144281f2ea
Author: Gregory W. Chicares <address@hidden>
Date:   Fri Jun 3 15:30:09 2016 +0000

    Remove misbegotten defect markers [442]
    
    mc_enum<T>::read() looks up a string to find an enumerator, but the
    strings and enumerators are available only in class mc_enum<T>, not in
    its base class mc_enum_base--so read() cannot be implemented in the
    base class.
---
 ce_product_name.hpp |    3 ---
 ce_skin_name.hpp    |    1 -
 mc_enum.hpp         |    1 -
 3 files changed, 5 deletions(-)

diff --git a/ce_product_name.hpp b/ce_product_name.hpp
index 686e597..f73cd91 100644
--- a/ce_product_name.hpp
+++ b/ce_product_name.hpp
@@ -58,8 +58,6 @@
 /// operation should really be performed only once. Alternatively, the
 /// program might write the 'sample' product's files if it finds no
 /// other product.
-///
-/// TODO ?? Can't read() and write() be moved to the base class?
 
 class ce_product_name
     :public mc_enum_base
@@ -89,7 +87,6 @@ class ce_product_name
 
   private:
     // datum_base required implementation.
-    // TODO ?? Consider moving the implementation into the base class.
     virtual std::istream& read (std::istream&);
     virtual std::ostream& write(std::ostream&) const;
 
diff --git a/ce_skin_name.hpp b/ce_skin_name.hpp
index 59ef375..deee488 100644
--- a/ce_skin_name.hpp
+++ b/ce_skin_name.hpp
@@ -71,7 +71,6 @@ class ce_skin_name
 
   private:
     // datum_base required implementation.
-    // TODO ?? Consider moving the implementation into the base class.
     virtual std::istream& read (std::istream&);
     virtual std::ostream& write(std::ostream&) const;
 
diff --git a/mc_enum.hpp b/mc_enum.hpp
index f138bfb..d128f8b 100644
--- a/mc_enum.hpp
+++ b/mc_enum.hpp
@@ -137,7 +137,6 @@ class mc_enum
     static std::vector<std::string> const& s();
 
     // datum_base required implementation.
-    // TODO ?? Consider moving the implementation into the base class.
     virtual std::istream& read (std::istream&);
     virtual std::ostream& write(std::ostream&) const;