[lmi-commits] [6422] For now, inhibit diagnostics added 20151106T1911Z and 20151107T1344Z

[Greg Chicares]

Revision: 6422
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6422
Author:   chicares
Date:     2015-11-23 16:47:18 +0000 (Mon, 23 Nov 2015)
Log Message:
-----------
For now, inhibit diagnostics added 20151106T1911Z and 20151107T1344Z

Modified Paths:
--------------
    lmi/trunk/input_harmonization.cpp
    lmi/trunk/ledger_invariant.cpp
    lmi/trunk/yare_input.cpp
    lmi/trunk/yare_input.hpp

Modified: lmi/trunk/input_harmonization.cpp
===================================================================
--- lmi/trunk/input_harmonization.cpp   2015-11-22 03:21:48 UTC (rev 6421)
+++ lmi/trunk/input_harmonization.cpp   2015-11-23 16:47:18 UTC (rev 6422)
@@ -1144,6 +1144,16 @@
     // multiple messageboxes, which is unavoidable if the diagnostic is
     // to be given when GUI input enters an invalid state, and also
     // whenever an illustration is about to be produced.
+// Fails:
+//   File | New | Illustration
+//   subtract one day from "Effective date"
+//   OK
+//   Illustration | Edit cell... [fails irrecoverably]
+// Therefore, these diagnostics are temporarily suppressed for input
+// files created by lmi--but not for extracts from vendor systems,
+// whose dates should not be altered by lmi users.
+if(1 != InforceDataSource.value())
+  {
     if(expected != InforceAsOfDate.value() && 
!contains(global_settings::instance().pyx(), "off_monthiversary"))
         {
         fatal_error()
@@ -1174,5 +1184,6 @@
             << LMI_FLUSH
             ;
         }
+  }
 }
 

Modified: lmi/trunk/ledger_invariant.cpp
===================================================================
--- lmi/trunk/ledger_invariant.cpp      2015-11-22 03:21:48 UTC (rev 6421)
+++ lmi/trunk/ledger_invariant.cpp      2015-11-23 16:47:18 UTC (rev 6422)
@@ -861,8 +861,21 @@
         )[0];
 
     IsInforce = b->yare_input_.EffectiveDate != b->yare_input_.InforceAsOfDate;
-    // This test is probably redundant, but it is difficult to prove
-    // that it is actually redundant and will always remain so.
+    // This test is probably redundant because it is already performed
+    // in class Input. But it's difficult to prove that it is actually
+    // redundant and will always remain so, while repeating it here
+    // costs little and gives a stronger guarantee that illustrations
+    // that would violate this rule cannot be produced.
+// Fails:
+//   File | New | Illustration
+//   subtract one day from "Effective date"
+//   OK
+//   Illustration | Edit cell... [fails irrecoverably]
+// Therefore, these diagnostics are temporarily suppressed for input
+// files created by lmi--but not for extracts from vendor systems,
+// whose dates should not be altered by lmi users.
+if(1 != b->yare_input_.InforceDataSource)
+  {
     if(IsInforce && (0 == b->yare_input_.InforceYear && 0 == 
b->yare_input_.InforceMonth))
         {
         fatal_error()
@@ -870,6 +883,7 @@
             << LMI_FLUSH
             ;
         }
+  }
 
     SupplementalReport         = b->yare_input_.CreateSupplementalReport;
     SupplementalReportColumn00 = 
mc_str(b->yare_input_.SupplementalReportColumn00);

Modified: lmi/trunk/yare_input.cpp
===================================================================
--- lmi/trunk/yare_input.cpp    2015-11-22 03:21:48 UTC (rev 6421)
+++ lmi/trunk/yare_input.cpp    2015-11-23 16:47:18 UTC (rev 6422)
@@ -108,6 +108,7 @@
     IncludeInComposite               = z.IncludeInComposite              
.value();
     Comments                         = z.Comments                        
.value();
     AmortizePremiumLoad              = z.AmortizePremiumLoad             
.value();
+    InforceDataSource                = z.InforceDataSource               
.value();
     ContractNumber                   = z.ContractNumber                  
.value();
     MasterContractNumber             = z.MasterContractNumber            
.value();
     InforceAsOfDate                  = z.InforceAsOfDate                 
.value();

Modified: lmi/trunk/yare_input.hpp
===================================================================
--- lmi/trunk/yare_input.hpp    2015-11-22 03:21:48 UTC (rev 6421)
+++ lmi/trunk/yare_input.hpp    2015-11-23 16:47:18 UTC (rev 6422)
@@ -148,7 +148,7 @@
     bool                              IncludeInComposite              ;
     std::string                       Comments                        ;
     bool                              AmortizePremiumLoad             ;
-//    std::string                       InforceDataSource               ;
+    int                               InforceDataSource               ;
     std::string                       ContractNumber                  ;
     std::string                       MasterContractNumber            ;
     calendar_date                     InforceAsOfDate                 ;