[lmi-commits] [6104] Further rectify test specifications

[Greg Chicares]

Revision: 6104
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6104
Author:   chicares
Date:     2015-01-26 16:56:18 +0000 (Mon, 26 Jan 2015)
Log Message:
-----------
Further rectify test specifications

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/wx_test_calculation_summary.cpp
    lmi/trunk/wx_test_validate_output.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2015-01-26 01:43:41 UTC (rev 6103)
+++ lmi/trunk/ChangeLog 2015-01-26 16:56:18 UTC (rev 6104)
@@ -35631,3 +35631,9 @@
   wx_test_paste_census.cpp
 Add a missing header: std::runtime_error requires <stdexcept>.
 
+20150126T1656Z <address@hidden> [516]
+
+  wx_test_calculation_summary.cpp
+  wx_test_validate_output.cpp
+Further rectify test specifications.
+

Modified: lmi/trunk/wx_test_calculation_summary.cpp
===================================================================
--- lmi/trunk/wx_test_calculation_summary.cpp   2015-01-26 01:43:41 UTC (rev 
6103)
+++ lmi/trunk/wx_test_calculation_summary.cpp   2015-01-26 16:56:18 UTC (rev 
6104)
@@ -316,6 +316,8 @@
 //  - Remove comment block (A) above: it's incorporated below.
 //  - Remove comment block (B) above: it's incorporated below, with
 //    only one column selected (twelve is overkill).
+//  - Remove comment blocks (C) and (D) above and their associated
+//    code: cf. 'wx_test_validate_output.cpp'.
 //  - Code the additional tests specified below.
 //  - Don't bother reading 'configurable_settings' directly: it cannot
 //    be wrong if all columns on the screen are correct.
@@ -323,9 +325,6 @@
 
 // Deferred ideas:
 //
-// Remove comment blocks (C) and (D) above: spreadsheet output is
-// tested elsewhere.
-//
 // Someday, test supplemental-report column selections similarly.
 //
 // To test backward compatibility, modify 'configurable_settings'
@@ -343,7 +342,10 @@
 ///
 /// Iff the '--distribution' option is specified, then:
 ///   File | Preferences
-/// make sure "Use built-in calculation summary" is checked.
+/// make sure that "Use built-in calculation summary" is checked, and
+/// that the saved selections (those that would become active if the
+/// checkbox were unchecked) exactly match the default selctions given
+/// by default_calculation_summary_columns().
 ///
 /// Display an illustration, to see calculation-summary effects:
 /// File | New | Illustration | OK

Modified: lmi/trunk/wx_test_validate_output.cpp
===================================================================
--- lmi/trunk/wx_test_validate_output.cpp       2015-01-26 01:43:41 UTC (rev 
6103)
+++ lmi/trunk/wx_test_validate_output.cpp       2015-01-26 16:56:18 UTC (rev 
6104)
@@ -142,6 +142,21 @@
 /// Verify that this file was created:
 ///   values.tsv
 ///
+/// select the "John Brown" cell
+/// Census | Run cell
+/// Illustration | Copy full illustration data [Ctrl-D]
+/// Verify that this file was created:
+///   ABC.John_Brown.000000001.ill.tsv
+/// and that its contents have been placed on the clipboard.
+///
+/// [These two functions:
+///   IllustrationView::UponCopyFull()    [Ctrl-D]
+///   IllustrationView::UponCopySummary() [Ctrl-C]
+/// are very similar, the former being almost a superset of the
+/// latter. Testing both seems unnecessary; and it would be less
+/// convenient to test the latter because it does not create a file.
+/// The (tested) Ctrl-D option is much likelier to be used.]
+///
 /// Finally, delete all files created directly or indirectly above
 /// that happen not to have been deleted already.