[lmi-commits] [6071] Improve failure reporting

[Greg Chicares]

Revision: 6071
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6071
Author:   chicares
Date:     2014-12-15 12:20:13 +0000 (Mon, 15 Dec 2014)
Log Message:
-----------
Improve failure reporting

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/wx_test_validate_output.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2014-12-15 12:03:16 UTC (rev 6070)
+++ lmi/trunk/ChangeLog 2014-12-15 12:20:13 UTC (rev 6071)
@@ -34869,3 +34869,9 @@
 Further simplify in the spirit of the 20141206T2004Z change. See:
   http://lists.nongnu.org/archive/html/lmi/2014-12/msg00029.html
 
+20141215T1220Z <address@hidden> [516]
+
+  wx_test_validate_output.cpp
+Improve failure reporting. See:
+  http://lists.nongnu.org/archive/html/lmi/2014-12/msg00068.html
+

Modified: lmi/trunk/wx_test_validate_output.cpp
===================================================================
--- lmi/trunk/wx_test_validate_output.cpp       2014-12-15 12:03:16 UTC (rev 
6070)
+++ lmi/trunk/wx_test_validate_output.cpp       2014-12-15 12:20:13 UTC (rev 
6071)
@@ -58,9 +58,9 @@
         fs::remove(path_);
         }
 
-    void assert_exists() const
+    bool exists() const
         {
-        LMI_ASSERT(fs::exists(path_));
+        return fs::exists(path_);
         }
 
     ~output_file_existence_checker()
@@ -159,7 +159,7 @@
     ill.close_discard_changes();
 
     // And check that this resulted in the creation of the expected file.
-    unnamed_trace.assert_exists();
+    LMI_ASSERT(unnamed_trace.exists());
 
     // Open an existing illustration already containing the same comment.
     wxUIActionSimulator ui;
@@ -181,7 +181,7 @@
     ui.Char('l', wxMOD_CONTROL);    // "File|Close"
     wxTEST_DIALOG(wxYield(), wxExpectModal<wxMessageDialog>(wxNO));
 
-    existing_trace.assert_exists();
+    LMI_ASSERT(existing_trace.exists());
 }
 
 LMI_WX_TEST_CASE(validate_output_mec)
@@ -206,7 +206,7 @@
     ui.Char('l', wxMOD_CONTROL);    // "File|Close"
     wxYield();
 
-    unnamed_output.assert_exists();
+    LMI_ASSERT(unnamed_output.exists());
 
     // And when opening an existing one.
     output_file_existence_checker existing_output("MecTesting.mec" + ext);
@@ -224,5 +224,5 @@
     ui.Char('l', wxMOD_CONTROL);    // "File|Close"
     wxYield();
 
-    existing_output.assert_exists();
+    LMI_ASSERT(existing_output.exists());
 }