[lmi-commits] [4871] Improve concinnity

[Greg Chicares]

Revision: 4871
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=4871
Author:   chicares
Date:     2010-04-29 23:51:30 +0000 (Thu, 29 Apr 2010)
Log Message:
-----------
Improve concinnity

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/alert.cpp
    lmi/trunk/callback_test.cpp
    lmi/trunk/catch_exceptions.hpp
    lmi/trunk/config_bc551.hpp
    lmi/trunk/cpp_main.cpp
    lmi/trunk/database_document.cpp
    lmi/trunk/dbvalue.cpp
    lmi/trunk/exit_codes.hpp
    lmi/trunk/ihs_irc7702.cpp
    lmi/trunk/multidimgrid_any.cpp
    lmi/trunk/numeric_io_traits.hpp
    lmi/trunk/rounding_view_editor.cpp
    lmi/trunk/stl_extensions.hpp
    lmi/trunk/test_main.cpp
    lmi/trunk/test_tools.hpp
    lmi/trunk/tier_view.cpp
    lmi/trunk/xml_lmi_fwd.hpp
    lmi/trunk/xml_serialize.hpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/ChangeLog 2010-04-29 23:51:30 UTC (rev 4871)
@@ -25127,3 +25127,35 @@
   workhorse.make
 Reimplement 'database' (formerly 'db4') product files (VS).
 
+20100429T2351Z <address@hidden> [745]
+
+  alert.cpp
+  callback_test.cpp
+  catch_exceptions.hpp
+  config_bc551.hpp
+  cpp_main.cpp
+  database_document.cpp
+  dbvalue.cpp
+  exit_codes.hpp
+  ihs_irc7702.cpp
+  multidimgrid_any.cpp
+  numeric_io_traits.hpp
+  rounding_view_editor.cpp
+  stl_extensions.hpp
+  test_main.cpp
+  test_tools.hpp
+  tier_view.cpp
+  xml_lmi_fwd.hpp
+  xml_serialize.hpp
+Improve concinnity. Write either:
+  namespace xyz
+  {
+  ...
+  } // namespace xyz
+so that grepping the opening leads to the closing; or:
+  namespace
+  {
+  ...
+  } // Unnamed namespace.
+which differs in that "Unnamed" is not the unnamed namespace's name.
+

Modified: lmi/trunk/alert.cpp
===================================================================
--- lmi/trunk/alert.cpp 2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/alert.cpp 2010-04-29 23:51:30 UTC (rev 4871)
@@ -93,7 +93,7 @@
         );
 #endif // defined LMI_MSW
 }
-} // Unnamed namespace
+} // Unnamed namespace.
 
 bool set_alert_functions
     (void(*status_alert_function_pointer        )(std::string const&)

Modified: lmi/trunk/callback_test.cpp
===================================================================
--- lmi/trunk/callback_test.cpp 2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/callback_test.cpp 2010-04-29 23:51:30 UTC (rev 4871)
@@ -62,7 +62,7 @@
             return adder_callback()(x,y,z);
             }
     };
-}
+} // namespace shared_library
 
 typedef shared_library::adder_fp_type FunctionPointer;
 template<> FunctionPointer callback<FunctionPointer>::function_pointer_ = 0;
@@ -83,7 +83,7 @@
         adder_initialize(concrete_adder);
     }
 
-} // Unnamed namespace.
+} // namespace application
 
 int test_main(int, char*[])
 {

Modified: lmi/trunk/catch_exceptions.hpp
===================================================================
--- lmi/trunk/catch_exceptions.hpp      2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/catch_exceptions.hpp      2010-04-29 23:51:30 UTC (rev 4871)
@@ -81,7 +81,7 @@
         ,char const*   info
         )
       {os << "\n** uncaught exception: " << name << " " << info << std::endl;}
-  }
+  } // namespace detail
 
   // catch_exceptions  ------------------------------------------------------//
 
@@ -185,7 +185,7 @@
         return result;
     } // catch_exceptions()
 
-} // Namespace lmi_test.
+} // namespace lmi_test
 
 #endif // catch_exceptions_hpp
 

Modified: lmi/trunk/config_bc551.hpp
===================================================================
--- lmi/trunk/config_bc551.hpp  2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/config_bc551.hpp  2010-04-29 23:51:30 UTC (rev 4871)
@@ -63,7 +63,7 @@
     using ::feof;
 #   undef ferror
     using ::ferror;
-    }
+    } // namespace std
 #include <cfloat>
     // COMPILER !! bc++5.5.1 got this wrong too.
     // See my post to borland.public.cppbuilder.language dated

Modified: lmi/trunk/cpp_main.cpp
===================================================================
--- lmi/trunk/cpp_main.cpp      2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/cpp_main.cpp      2010-04-29 23:51:30 UTC (rev 4871)
@@ -134,8 +134,8 @@
         cpp_main_caller(int c, char** v) : argc(c), argv(v) {}
         int operator()() {return cpp_main(argc, argv);}
     };
-  }
-} // Namespace lmi_test.
+  } // namespace test
+} // namespace lmi_test
 
 int main(int argc, char* argv[])
 {

Modified: lmi/trunk/database_document.cpp
===================================================================
--- lmi/trunk/database_document.cpp     2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/database_document.cpp     2010-04-29 23:51:30 UTC (rev 4871)
@@ -70,7 +70,7 @@
     m1_.swap(m2_); // swap back
 }
 
-} // unnamed namespace
+} // Unnamed namespace.
 
 IMPLEMENT_DYNAMIC_CLASS(DatabaseDocument, ProductEditorDocument)
 

Modified: lmi/trunk/dbvalue.cpp
===================================================================
--- lmi/trunk/dbvalue.cpp       2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/dbvalue.cpp       2010-04-29 23:51:30 UTC (rev 4871)
@@ -42,7 +42,7 @@
         for(SIZE_T j = 0; j < n; j++)
             dest[j] = value[j];
     }
-}
+} // namespace deprecated
 
 //============================================================================
 TDBValue::TDBValue()

Modified: lmi/trunk/exit_codes.hpp
===================================================================
--- lmi/trunk/exit_codes.hpp    2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/exit_codes.hpp    2010-04-29 23:51:30 UTC (rev 4871)
@@ -81,7 +81,7 @@
     int const exit_exception_failure = 200; // otherwise uncaught exception
     int const exit_test_failure = 201;      // report_error or
                                             // report_critical_error called.
-} // Namespace lmi_test.
+} // namespace lmi_test
 
 #endif // exit_codes_hpp
 

Modified: lmi/trunk/ihs_irc7702.cpp
===================================================================
--- lmi/trunk/ihs_irc7702.cpp   2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/ihs_irc7702.cpp   2010-04-29 23:51:30 UTC (rev 4871)
@@ -76,13 +76,10 @@
         static std::vector<double> const v(d, d + n);
         return v;
         }
-}
 
-namespace
-{
     // Use 7702 int rate for DB discount in NAAR
     bool g_UseIcForIg = true;
-}
+} // Unnamed namespace.
 
 // General concerns
 //
@@ -1043,7 +1040,7 @@
             return SpecAmt;
             }
     };
-//}
+//} // Unnamed namespace.
 
 //============================================================================
 // CalculatePremium() implements an analytic solution, while CalculateSpecAmt()

Modified: lmi/trunk/multidimgrid_any.cpp
===================================================================
--- lmi/trunk/multidimgrid_any.cpp      2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/multidimgrid_any.cpp      2010-04-29 23:51:30 UTC (rev 4871)
@@ -202,7 +202,7 @@
         }
 }
 
-} // unnamed namespace
+} // Unnamed namespace.
 
 /// GridRefreshTableDataGuard: Table refresh guard class
 ///
@@ -283,7 +283,7 @@
     return MDGRID_AXIS_ROW + n * 2 + 1;
 }
 
-} // unnamed namespace
+} // Unnamed namespace.
 
 void MultiDimGrid::Init()
 {

Modified: lmi/trunk/numeric_io_traits.hpp
===================================================================
--- lmi/trunk/numeric_io_traits.hpp     2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/numeric_io_traits.hpp     2010-04-29 23:51:30 UTC (rev 4871)
@@ -47,7 +47,7 @@
     {
         return static_cast<T>(u);
     }
-}
+} // namespace boost
 #endif // defined __BORLANDC__
 
 // Number of exact decimal digits to the right of the decimal point.

Modified: lmi/trunk/rounding_view_editor.cpp
===================================================================
--- lmi/trunk/rounding_view_editor.cpp  2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/rounding_view_editor.cpp  2010-04-29 23:51:30 UTC (rev 4871)
@@ -142,7 +142,7 @@
         ));
 }
 
-} // unnamed namespace
+} // Unnamed namespace.
 
 BEGIN_EVENT_TABLE(RoundingButtons, wxPanel)
     EVT_BUTTON(e_rbi_not_at_all, RoundingButtons::UponButtonClick)

Modified: lmi/trunk/stl_extensions.hpp
===================================================================
--- lmi/trunk/stl_extensions.hpp        2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/stl_extensions.hpp        2010-04-29 23:51:30 UTC (rev 4871)
@@ -119,7 +119,7 @@
 
     return true;
 }
-} // Unnamed namespace.
+} // namespace nonstd
 
 #endif // stl_extensions_hpp
 

Modified: lmi/trunk/test_main.cpp
===================================================================
--- lmi/trunk/test_main.cpp     2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/test_main.cpp     2010-04-29 23:51:30 UTC (rev 4871)
@@ -85,7 +85,7 @@
       public:
         test_tools_exception() : std::runtime_error("fatal test error") {};
     };
-  } // Namespace test.
+  } // namespace test
 
     std::ostream& error_stream()
     {
@@ -101,7 +101,7 @@
     {
         ++test::test_tools_successes;
     }
-} // Namespace lmi_test.
+} // namespace lmi_test
 
 // cpp_main()  --------------------------------------------------------------//
 

Modified: lmi/trunk/test_tools.hpp
===================================================================
--- lmi/trunk/test_tools.hpp    2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/test_tools.hpp    2010-04-29 23:51:30 UTC (rev 4871)
@@ -271,7 +271,7 @@
 
     void record_error();
     // Effect: increment test_tools_errors counter.
-} // Namespace lmi_test.
+} // namespace lmi_test
 
 // For convenience, include lower-level layers. The original boost
 // library did this only if BOOST_INCLUDE_MAIN had been defined; that

Modified: lmi/trunk/tier_view.cpp
===================================================================
--- lmi/trunk/tier_view.cpp     2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/tier_view.cpp     2010-04-29 23:51:30 UTC (rev 4871)
@@ -94,7 +94,7 @@
     return entity_info_;
 }
 
-} // unnamed namespace
+} // Unnamed namespace.
 
 IMPLEMENT_DYNAMIC_CLASS(TierView, TreeGridViewBase)
 

Modified: lmi/trunk/xml_lmi_fwd.hpp
===================================================================
--- lmi/trunk/xml_lmi_fwd.hpp   2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/xml_lmi_fwd.hpp   2010-04-29 23:51:30 UTC (rev 4871)
@@ -38,7 +38,7 @@
     /// nodes that are not elements; xmlwrapp doesn't make this
     /// distinction, but a future replacement might.
     typedef xml::node element;
-} // Namespace xml.
+} // namespace xml
 
 /// Interface to xmlwrapp.
 

Modified: lmi/trunk/xml_serialize.hpp
===================================================================
--- lmi/trunk/xml_serialize.hpp 2010-04-29 19:13:13 UTC (rev 4870)
+++ lmi/trunk/xml_serialize.hpp 2010-04-29 23:51:30 UTC (rev 4871)
@@ -172,7 +172,7 @@
 {
     xml_io<T>::from_xml(e, t);
 }
-} // Namespace xml_serialize.
+} // namespace xml_serialize
 
 #endif // xml_serialize_hpp