Re: [Linphone-users] Linphone 3.6.1 for Ubuntu -- multiple compilation warning/error bugs and deprecated functions

[Guillaume Beraudo]

Hi,


Compiling ortp without zrtp should work out of the box.
On master, configure.ac effectively contains:
AC_ARG_ENABLE(zrtp,
        [AS_HELP_STRING([--enable-zrtp], [Turn on or off compilation of zrtp 
(GPLv3+ only) (default=no)])],
        [case "${enableval}" in
                yes)    zrtp=true ;;
                no)     zrtp=false ;;
                *)      AC_MSG_ERROR(bad value ${enableval} for --enable-zrtp) 
;;
        esac],
        [zrtp=false]
)

if test "$zrtp" = "true" ; then
        PKG_CHECK_MODULES(LIBZRTPCPP, libzrtpcpp >= 3.0.0,
                [AC_DEFINE(HAVE_zrtpcpp_with_len, 1, [Defined when zrtpcpp 
requires added len param])],
                [PKG_CHECK_MODULES(LIBZRTPCPP, libzrtpcppcore >= 2.0.0,
                        [],
                        [PKG_CHECK_MODULES(LIBZRTPCPP, libzrtpcpp >= 2.0.0)]
                )]
        )
        if test "$have_srtp" = "no" ; then
                AC_MSG_ERROR("ZRTP requires SRTP")
        fi
        AC_DEFINE(HAVE_zrtp, 1, [Defined when zrtp support is compiled])
else
        echo "ZRTP compilation is disabled."
fi



I fixed the unused variable in pasnd, in mediastreamer master.


Regarding ffmeg deprecations, do you use libav or libffmpeg?
Could you have a look to commits 9b3487265555c933375ce932f4e3e6511cf532dd
and c799531d9403c50fb06965a921e1530c814e02a1 and send a patch for any missing
components.


Cheers,

Guillaume Beraudo


On Fri, Jul 12, 2013 at 09:58:29PM +0200, J G Miller wrote:
> At 09:40h, on Friday, July 12, 2013,
> in message <address@hidden>,
> on the subject of "Re: [Linphone-users] Linphone 3.6.1 for Ubuntu",
> "Elizabeth W." <address@hidden> wrote -
> 
>  > That was actually what I tried to do originally before asking the mailing
>  > list about Ubuntu packages for 3.6.
>  > Maybe someone on here can help me: the build would fail because it would
>  > require the srtp library (it would fail at build with something like
>  > "missing packages: srtp") regardless of what flags I tried for configure
>  > and build.
> 
> I am just in the process of trying to compile and install the latest linphone 
> 3.6.1
> on Linux Mint 14 Nadia (Ubuntu 12.10 Quantal Quetzal).
> 
> In order to avoid building the git version of srtp and causing possible 
> library
> conflicts with other applications, I am compiling without srtp support.
> 
> To achieve this, it appears that there is no --disable-zrtp flag only
> an "--enable-zrtp           Turn on zrtp support".
> 
> The configure script fails to honor this flag not being as it checks to see
> if there are libzrtpcpp regardless.
> 
> So to build linphone without the zrtcpp and thus without needing the git 
> version
> of srtp, for the duration of the compilation ensure that you do not have the
> zrtcpp headers present on the system viz
> 
>        dpkg --purge libsrtp0-dev libzrtpcpp-dev
> 
> After you have run configure, you can of course reinstall them if you need
> them for building other software.
> 
> Also if you are using gcc, you are going to run into a compilation problem in
> the mediastreamer2 directory.  Treat all warnings as errors has been set
> except for -Wno-error=deprecated-declarations, but there is an unused 
> variable vad
> in audiofilters/pasnd.lo:
> 
>   CC     audiofilters/pasnd.lo
>   audiofilters/pasnd.c: In function 'WaveInCallback':
>   audiofilters/pasnd.c:115:11: error: variable 'vad' set but not used 
> [-Werror=unused-but-set-variable]
>   cc1: all warnings being treated as errors
>   make[5]: *** [audiofilters/pasnd.lo] Error 1
>   make[5]: Leaving directory `/usr/src/build/linphone-3.6.1/mediastreamer2/src
> 
> and then the issue of implicit declaration of function in 
> videofilters/videoenc.c:
> 
>   CC     videofilters/videoenc.lo
>   videofilters/videoenc.c: In function 'prepare':
>   videofilters/videoenc.c:245:2: error: implicit declaration of function 
> 'avcodec_get_context_defaults' [-Werror=implicit-function-declaration]
>   videofilters/videoenc.c: In function 'enc_preprocess':
>   videofilters/videoenc.c:351:2: error: implicit declaration of function 
> 'avcodec_open' [-Werror=implicit-function-declaration]
>   videofilters/videoenc.c: In function 'process_frame':
>   videofilters/videoenc.c:800:2: warning: 'avcodec_encode_video' is 
> deprecated (declared at /usr/local/X11R6/include/libavcodec/avcodec.h:4030) 
> [-Wdeprecated-declarations]
>   cc1: all warnings being treated as errors
>   make[5]: *** [videofilters/videoenc.lo] Error 1
>   make[5]: Leaving directory 
> `/usr/src/build/linphone-3.6.1/mediastreamer2/src'
> 
> and then there is the error in videofilters/jpegwriter.c
> 
>   videofilters/jpegwriter.c:93:26: error: initialization makes pointer from 
> integer without a cast [-Werror]
> 
> And then once all those issues have been resolved
> 
> Making all in tools
> make[2]: Entering directory 
> `/usr/src/build/linphone-3.6.1/mediastreamer2/tools'
>   CC     mediastream.o
>   CCLD   mediastream
> ../src/.libs/libmediastreamer_voip.so: undefined reference to 
> `avcodec_get_context_defaults'
> ../src/.libs/libmediastreamer_voip.so: undefined reference to `avcodec_open'
> ../src/.libs/libmediastreamer_voip.so: undefined reference to 
> `avcodec_alloc_context'
> collect2: error: ld returned 1 exit status
> make[2]: *** [mediastream] Error 1
> make[2]: Leaving directory 
> `/usr/src/build/linphone-3.6.1/mediastreamer2/tools'
> 
> 
> These three functions are all deprecated in 
> 
>       libavcodec53   6:0.8.6-0ubuntu0.12.10
> 
> so why they have been left in the code is anybody's guess.
> 
> _______________________________________________
> Linphone-users mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-users