[Linphone-developers] linphone-3.5.2 bug report

[David Binderman]

Hello there, 

I just tried the static analyser "cppcheck" over the source code
of linphone-3.5.2 It said

1.

[sal_eXosip2.c:1332] -> [sal_eXosip2.c:1335]: (warning) Variable 'error' is 
reassigned a value before the old one has been used. 'break;' missing?
[sal_eXosip2.c:1333] -> [sal_eXosip2.c:1336]: (warning) Variable 'sr' is 
reassigned a value before the old one has been used. 'break;' missing?

The source code is

        case 480:
            error=SalErrorFailure;
            sr=SalReasonTemporarilyUnavailable;
        case 486:
            error=SalErrorFailure;
            sr=SalReasonBusy;
        break;

Suggest add break.

2.

Some off by one errors

[sal_eXosip2_sdp.c:425]: (error) Width 256 given in format string (no. 2) is 
larger than destination buffer 'tmp[256]', use %255s to prevent overflowing it.
[sal_eXosip2_sdp.c:425]: (error) Width 256 given in format string (no. 3) is 
larger than destination buffer 'tmp2[256]', use %255s to prevent overflowing it.

3. A couple of resource leaks on error handling paths

[linphonec.c:1403]: (error) Resource leak: in
[linphonec.c:1411]: (error) Resource leak: out

Regards

David Binderman