Re: [Linphone-developers] Proximity sensor fix for Droid/Milestone

[Simon Morlat]

Hi Enrique,

Thanks a lot for your analysis and suggested bugfix. We'll try it and
check it isn't breaking anything on other phones, and if ok push it for
next release.

Best regards,

Simon

Le jeudi 12 août 2010 à 16:00 -0300, Henrique Grolli a écrit :
> I downloaded linphone for my Brazilian Milestone and realize the
> proximity sensor wasnt doing anything on the softphone. After checking
> out the "Android Sensor Data" app source code
> (ref: http://code.google.com/p/abscideturasd/) and the linphone source
> code. I found a different kind of comparison of sensor data as
> fallows:
> 
> 
> Android Sensor Data do the fallowing comparison:
> if (event.values[0] <= 3) {
> 
> 
> And linphone was doing:
> if (LinphoneService.instance().getLinphoneCore().isIncall()  &&
> event.values[0] != event.sensor.getMaximumRange() && event.values[0] <
> 3) {
> 
> 
> So i changed to:
> if (LinphoneService.instance().getLinphoneCore().isIncall() &&
> event.values[0] <= 3.0) {
> 
> 
> Built a test apk and it worked like a charm. I couldn't test it on
> other phones but since Android Sensor Data works on most phones it
> should be fine. The patch for LinphoneActivity.java is attached for
> review. Thanks for this great software, best softphone i found for
> android by far.
> -- 
> Henrique Grolli Bassotto
> 
> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/linphone-developers