[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Linphone-developers] g_warning vs. vtable.display_warning
From: |
strk |
Subject: |
Re: [Linphone-developers] g_warning vs. vtable.display_warning |
Date: |
Thu, 26 Jan 2006 11:26:38 +0100 |
Having done some more tests I'm convinced linphone core
should use its own warning/message/error functions.
In this way use of the functions set in the virtual
table can be triggered by both availability of them
(!=NULL) and possibly other settings (verbosity level?).
--strk;
On Thu, Jan 26, 2006 at 02:43:15AM +0100, strk wrote:
> linphonecore.c contains many invokations of g_warning(msg).
> I don't get those messages from the command line interface,
> and I'm not sure the GUI does in any way.
>
> Would it be correct to substitute all g_warning() occurrences
> with LinephoneCore.vtable.display_warning() instead ?
>
> There are already two uses of it.
> One is to warn about UDP port being in use
> and the other about invalid sip address.
>
> Note that the second one checks for the vtable entry
> to be non-null, while the first doesn't. What would
> the correct way be ?
>
> --strk;