[Linphone-developers] RTP sessions not being removed from oRTP scheduler

[Evan Pfeiffer]

A comment on what appears to be a bug in oRTP.

When an RTP session is removed using rtp_session_destroy() it is not removed 
from the scheduler if the session has not sent or received any packets.

This seems erroneous as the scheduler will be left with a session that has been 
deallocated by rtp_session_destroy(). Shouldn't a session that has been added to 
the scheduler always be removed by rtp_session_uninit()?

I suggest the following patch to rtpsession.c (diff generated for oRTP 0.6.2)


1479,1481c1479
<            if ((!(session->flags & RTP_SESSION_RECV_NOT_STARTED))
<                    || (!(session->flags & RTP_SESSION_SEND_NOT_STARTED)))
<                      rtp_scheduler_remove_session (session->sched,session);
---
>            rtp_scheduler_remove_session (session->sched,session);


Regards,
Evan