Re: Second review of NR 2.7 Chords

[Neil Puttock]

Hi Carl,

You've done a great job with this.

There are a few details which I'd like to mention:

- chords-headword.ly:

Further to Andrew's comments about the G flat (it should be an F
sharp), the chord names seem to be a bit off. For example, in the
second bar, the first chord has a 'C' above it; it's actually a first
inversion G chord.

- Chord mode overview:

The snippets have inconsistent spacing, e.g. < g b d > and \chordmode
{ c2 f}. Each line should have a duration.

- Extended and altered chords:

Typo: "To alter a step that is automatically included as part of the
basic >chode< structure, add it as an altered step."

Style nit: "\chords { ... } is a shortcut notation for \new ChordNames
{\chordmode { ... }}." - needs spaces around \chordmode { }.

- Printing chord names:

`See also' is missing some IR links, e.g., ChordName, Chord_name_engraver.

- Customizing chord names:

Typo: "This property contains the markup object used to follow the
output of chordRootNamer to >dentify< a major 7 chord."

Style nit: "By setting chordNameSeparator, >you< can use any desired
markup for a separator."

Typo: "The second item is a >markups< that will follow the
chordRootNamer output to create the chord name."

Style nit: "By setting chordPrefixSpacer, >you< can fix a spacer
between the root and 'm'."

In selected snippets, chord-name-exceptions.ly and
chord-name-major7.ly aren't displayed properly (no title, lacking
%begin verbatim so the texidoc and version are visible) since there
are snippets with these names present in input/regression; they take
precedence over the LSR versions.

In `Known issues and warnings', the snippet is missing a space after \chordmode.


- Introduction to figured bass:

The introductory snippet would look better if the second bar were complete.

Style nit: "\figures{ ... } is a shortcut notation for \new
FiguredBass {\figuremode { ... }}." - spaces around \figuremode { }.

At the bottom of the page, baseline-skip is given as an example of
markup properties which can be used to alter bass figures. This only
works if you stick \markup \column in each figure construct, so it's
not really a viable usage. The proper method would be to override
BassFigureAlignment #'padding; perhaps we could add a snippet
demonstrating this?

- Entering figured bass:

"Augmented and diminished steps can be indicated." - missing colon.

"A backward slash through a figure (typically used for raised sixth
steps) can be created." - missing colon. Unlike the others, the
demonstration snippet has the figures on separate lines.

"Any text markup can be inserted as a figure:" - snippet style nits:

     <  \markup{ \tiny \number 6 \super (1)} 5 >  ->   <\markup {
\tiny \number 6 \super (1) } 5>

"Continuation lines can be used to indicate repeated figures:" - both
snippets are missing durations.

The "End of continuation line" modifier snippet is a bit cramped (its
line-width is 1.5 cm).

- Displaying figured bass

"When added in a Staff context, figured bass can be displayed above or
below the staff." - @code{Staff}

`Known issues and warnings': \repeat unfold { } lacking spaces around
notes; { fis g g, e' } -> { fis4 g g, e' }.

I think that's everything. :)

Regards,
Neil