lilypond-user
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Duration dots and Bar lines on custom Staves.


From: Neil Puttock
Subject: Re: [PATCH] Re: Duration dots and Bar lines on custom Staves.
Date: Sun, 10 Aug 2008 09:50:05 +0100

2008/8/10 Joe Neeman <address@hidden>:

> I think Han-Wen's point is that the first argument to
> Staff_symbol::some_function(Grob *me, ...) should always be a staff
> symbol (whereas the first argument to
> Staff_symbol_referencer::some_function(Grob *me, ...) should be a staff
> symbol referencer).

That makes sense.

> In other words, the old code was ok but it isn't ok for
> Staff_symbol::on_line to accept something that isn't a staff symbol.

Since that's the case, what do you think of the revised patch I
posted, which moves all the code back to staff-symbol-referencer.cc?
We currently have the situation where 2.11.52-2 is broken for
augmentation dots and ties, so this needs sorting out.  If you don't
think the patch is suitable, perhaps we should just revert the leger
line patch and revisit it later.

Regards,
Neil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]