[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: C++ cleanup : get rid of some compilation warnings (issue 353880043
|
From: |
lemzwerg |
|
Subject: |
Re: C++ cleanup : get rid of some compilation warnings (issue 353880043 by address@hidden) |
|
Date: |
Tue, 19 Feb 2019 05:46:56 -0800 |
https://codereview.appspot.com/353880043/diff/2/lily/main.cc
File lily/main.cc (right):
https://codereview.appspot.com/353880043/diff/2/lily/main.cc#newcode635
lily/main.cc:635: { }; // ignore option for backwards compatibility
On 2019/02/19 12:55:10, dak wrote:
This code is insane. Maybe just outcomment the whole else if branch
instead?
Well, option `--relocate' should (1) be recognized (i.e., it shouldn't
produce an error), but at the same time it should (2) be a no-op.
Removing the branch would disable (1)...
https://codereview.appspot.com/353880043/