[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Improve relocation debug messages. (issue 347070043 by address@hidde
|
From: |
dak |
|
Subject: |
Re: Improve relocation debug messages. (issue 347070043 by address@hidden) |
|
Date: |
Fri, 08 Feb 2019 02:36:44 -0800 |
On 2019/02/08 09:49:58, lemzwerg wrote:
On 2019/02/08 09:42:27, dak wrote:
> https://codereview.appspot.com/347070043/diff/1/lily/relocate.cc
> File lily/relocate.cc (right):
>
>
https://codereview.appspot.com/347070043/diff/1/lily/relocate.cc#newcode128
> lily/relocate.cc:128: TOPLEVEL_VERSION, package_datadir));
> Why no .c_str () here (and lots of other places)?
Why should it? It works without `c_str'. Am I missing something?
Well, we do prefer code that works by design rather than code that works
by mere chance and due to idiosyncrasies of the GNU C++ library. _f
needs zero-terminated strings for %s format fields but being a C-style
format string, cannot enforce the respective conversions.
Can you give any reason why it _should_ work rather than "I tried"?
https://codereview.appspot.com/347070043/