|
From: | Malte Meyn |
Subject: | Re: makelsr |
Date: | Fri, 28 Dec 2018 15:04:02 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Am 28.12.18 um 13:13 schrieb Thomas Morley:
James askes not to run makelsr, because a plethora of changes will clutter the patch-set. OTOH, a patch can't stand alone and can't be applied for testings by reviewers without makelsr. So I voted for doing makelsr. The CG is not clear in this regard (or I didn't understand it)
From section 7.2 of the CG:“Please ask a documentation editor to add a reference to it in an appropriate place in the docs. (Note – it should appear in the snippets document automatically, once it has been imported into git and built. See LSR to Git.”
This sounds unclear to me too. And who is a documentation editor if not me who added the LSR snippet?
Probably making a makelsr patch first like you suggested (https://sourceforge.net/p/testlilyissues/issues/5251/#612b/c337) is the easiest way. Who would do that? Would this go the normal review way (git-cl, Rietveld, sourceforge issue) or are there some trusted/experienced developers who can do this without? (I think I would be able to do that and take the warning at http://lilypond.org/doc/v2.19/Documentation/contributor/lsr-to-git seriously enough but of course there are some more experienced people who know more about documentation and LSR than I do.)So how to deal with it?
[Prev in Thread] | Current Thread | [Next in Thread] |