[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5251/1: set default restNumberThreshold = 1 (issue 353850043 b
|
From: |
lilypond |
|
Subject: |
Re: Issue 5251/1: set default restNumberThreshold = 1 (issue 353850043 by address@hidden) |
|
Date: |
Thu, 27 Dec 2018 13:05:58 -0800 |
https://codereview.appspot.com/353850043/diff/1/Documentation/snippets/new/numbering-single-measure-rests.ly
File Documentation/snippets/new/numbering-single-measure-rests.ly
(right):
https://codereview.appspot.com/353850043/diff/1/Documentation/snippets/new/numbering-single-measure-rests.ly#newcode14
Documentation/snippets/new/numbering-single-measure-rests.ly:14:
\relative {
On 2018/12/27 20:58:55, thomasmorley651 wrote:
On 2018/12/27 14:35:18, Malte Meyn wrote:
> I can’t find the snippet using the search function; why?
You mean in LSR?
New approved snippets are usually available with a day delay. I'd try
tomorrow.
Yes, I meant in LSR; I’ll try tomorrow and then upload a second patch
set.
Because 'numbering-single-measure-rests.ly' is compilable with 2.18.
you
probably can omit it here entirely, if you run make-lsr.
Not sure, though. Please check.
Will do.
> I followed James’s directions
>
(https://lists.gnu.org/archive/html/lilypond-devel/2018-12/msg00153.html),
> that’s why I didn’t do the makelsr.py run.
I'd do so to warrant stand-alone compilation-ability of this
patch-set.
But that's only me.
Others?
Hm … I’ll try. If I did it correctly, the makelsr “noise” James
mentioned is not that much. And of course I’d make separate commits but
that doesn’t have to be separate patch sets or even issues here on
Rietveld.
https://codereview.appspot.com/353850043/