Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by address@hidden)

[David Kastrup]

Torsten Hämmerle <address@hidden> writes:

> David Kastrup wrote
>> Once you create a smobbed copy, it must be protected from garbage
>> collection.
>> […]
>> However, it seems that uses here are few enough that you can just do
>> SCM q = s->smobbed_copy ();
>> and use unsmob
>> <Stencil>
>>  (q) where you now use q.
>
>
> Hi David,
>
> Many thanks for your review and the valuable hint.
>
> I'll have to admit not having thought about garbage collection and therefore
> just used a single line instead of declaring an extra SCM variable.
>
> What's the best method to correct this (as the issue already has the status
> "fixed")?
> Reuse the issue or create a new one? (perhaps together with another slight
> change to lily/stencil-integral.cc concerning issue 5307, cf. your 2nd
> skyline posting).

New one.  Best keep it separate since this is sort of an urgent one and
would warrant getting fast-tracked.

-- 
David Kastrup