[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sort input files (issue 347770043 by address@hidden)
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: sort input files (issue 347770043 by address@hidden) |
|
Date: |
Thu, 07 Jun 2018 13:37:28 -0700 |
https://codereview.appspot.com/347770043/diff/20001/stepmake/stepmake/c++-vars.make
File stepmake/stepmake/c++-vars.make (right):
https://codereview.appspot.com/347770043/diff/20001/stepmake/stepmake/c++-vars.make#newcode23
stepmake/stepmake/c++-vars.make:23: O_FILES+=$(addprefix $(outdir)/,
$(sort $(CC_FILES:.cc=.o) $(LL_FILES:.ll=.o) $(YY_FILES:.yy=.o)))
After closer inspection, I take back "if it works for you, fine." I
don't think this patch accomplishes what is intended. This line
mentions objects produced from .ll and .yy files, neither of which are
sorted.
I reiterate my earlier suggestion. If you want to be sure that the
arguments of a specific command are sorted, call sort on that very line.
https://codereview.appspot.com/347770043/