|
| From: | Carl . D . Sorensen |
| Subject: | Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by address@hidden) |
| Date: | Tue, 24 Apr 2018 10:59:31 -0700 |
LGTM. I am just a *little* bit concerned about having the dimensions of the Emmentaler natural glyph hardcoded in the source, but we already have magic numbers reflecting the characteristics of the Emmentaler glyphs. Maybe it would be good to put a FIXME in recognizing this fact. Or maybe we just go as-is. https://codereview.appspot.com/343020043/
| [Prev in Thread] | Current Thread | [Next in Thread] |