|
| From: | dak |
| Subject: | Re: Issue 5310: find_top_context () maintenance (issue 341150043 by address@hidden) |
| Date: | Sat, 21 Apr 2018 13:58:32 -0700 |
https://codereview.appspot.com/341150043/diff/1/lily/context.cc File lily/context.cc (right): https://codereview.appspot.com/341150043/diff/1/lily/context.cc#newcode723 lily/context.cc:723: find_top_context (Context &where) What problem are you trying to fix here? find_top_context worked given a null pointer before your change. This is no longer the case afterwards since a reference is guaranteed not to refer to a null vma. And it was simpler to understand and debug. https://codereview.appspot.com/341150043/
| [Prev in Thread] | Current Thread | [Next in Thread] |