[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add lilypond version predicates/operators (issue 317270043 by addres
From: |
git |
Subject: |
Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden) |
Date: |
Tue, 14 Feb 2017 07:46:20 -0800 |
On 2017/02/14 15:37:35, pwm wrote:
On 2017/02/14 15:15:07, git wrote:
> I like this more because it's more of a typical procedure
invocation.
> I think I'll create a new patch with this and a simplified
calculate-version
> (that doesn't accept string lists)
Well, having the procedure as the first argument might be more
scheme-ish?
Maybe best would be to have a "version-compare" function that compares
two
version lists using a procedure. Then define "ly:version?" so it
calls
"version-compare" with the current LilyPond version (to handle the
primary use
case). The "version-compare" function could be David's looping
function, but
modified so that it took two version lists and a procedure as
arguments.
This is what I'm currently working on.
However, I found an issue in David's suggestion, namely the
(op 0 0) ;; return #t iff op includes equality
line.
This makes the function return #t when comparing with = and one list
shortened
Try e.g. (ly:version? = 2 16)
This returns #t because in the third iteration when the reference
version has
run out of elements it compares 0 to 0.
https://codereview.appspot.com/317270043/
- Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), paulwmorris, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), git, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), git, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), paulwmorris, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden),
git <=
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), git, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), git, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), dak, 2017/02/14
- Re: Add lilypond version predicates/operators (issue 317270043 by address@hidden), thomasmorley65, 2017/02/14