lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Allow multiple \with per context creation (issue 296470043 by address@hi


From: nine . fierce . ballads
Subject: Allow multiple \with per context creation (issue 296470043 by address@hidden)
Date: Sat, 18 Jun 2016 05:42:19 -0700

LGTM


https://codereview.appspot.com/296470043/diff/1/lily/parser.yy
File lily/parser.yy (right):

https://codereview.appspot.com/296470043/diff/1/lily/parser.yy#newcode1497
lily/parser.yy:1497: context_modification_mods_list:
Comments as simple as these would help a person find his bearings in
this file:

/* a series of \with ... \with ... */
context_modification_mods_list

/* the statements inside a \with block */
context_mod_list

More distinctive names would be preferred.  (I know that's hard.)  Maybe
the "modification_mods_list" could be "modification_group_list" or
something like that.

https://codereview.appspot.com/296470043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]