Re: Allow override of NoteHead.ledger-positions (issue 295970043 by address@hidden)

[dak]

https://codereview.appspot.com/295970043/diff/1/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):

https://codereview.appspot.com/295970043/diff/1/lily/ledger-line-spanner.cc#newcode221
lily/ledger-line-spanner.cc:221: int len = scm_to_int (scm_length
(posns));
scm_ilength already does scm_to_int.  But if you are getting the size of
the vector in advance anyway (rather than just do {...} while
(scm_is_pair (posns));), why don't you dimension the vector in advance?

But at any rate, wouldn't it be better to just pass an optional grob
argument to Staff_symbol::ledger_positions so that this function will
extract the ledger-positions preferably from this extra argument?  That
way the extraction code is all in one place.

https://codereview.appspot.com/295970043/