Re: Add comment to font.scm and lilypond-fonts.conf.in (issue 257940043 by address@hidden)

[pkx166h]

Reviewers: trueroad,

Message:
On 2015/07/27 12:10:24, trueroad wrote:
> https://codereview.appspot.com/257940043/diff/1/scm/font.scm
> File scm/font.scm (right):


https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254
> scm/font.scm:254: ; are aliases that are defined in
mf/lilypond-fonts.conf.in.
> `mf/lilypond-fonts.conf.in' is filename in the source files.
> It is changed by makefiles at building lilypond binaries and
installers.
> Its installed filename is `font/lilypond-fonts.conf'.

Maybe I am missing something - I am not a programmer - we cannot add
comments in files that don't exist in the source but that are generated
when they are 'made' (or built or whatever term you use). So as the file
font/lilypond-fonts.conf doesn't actually exist, I don't know how else
we would be able to tell the user what these 'LilyPond' fonts mean. Or
did I misunderstand what you are telling me here? Sorry if that is the
case.

Description:
Add comment to font.scm and lilypond-fonts.conf.in

From comments in:

http://lists.gnu.org/archive/html/
lilypond-devel/2015-06/msg00175.html

Added appropriate comments
in scm/font.scm and
mf/lilypond-fonts.conf.in

Please review this at https://codereview.appspot.com/257940043/

Affected files (+9, -1 lines):
  M mf/lilypond-fonts.conf.in
  M scm/font.scm


Index: mf/lilypond-fonts.conf.in
diff --git a/mf/lilypond-fonts.conf.in b/mf/lilypond-fonts.conf.in
index  
c26183f7546940e5d34527c2321b6a20d701b74c..e32baf81473a1e0f4880032e7e9a82bdedecf9de  
100644
--- a/mf/lilypond-fonts.conf.in
+++ b/mf/lilypond-fonts.conf.in
@@ -2,7 +2,11 @@
 <!DOCTYPE fontconfig SYSTEM "fonts.dtd">
 <fontconfig>

-  <!-- Define LilyPond default fonts -->
+  <!--
+  Define LilyPond default fonts. Where a character doesn't exist in the
+  first font listed, the next font listed will be used instead for that
+  character. Also see scm/font.scm.
+  -->

   <alias binding="strong">
     <family>LilyPond Serif</family>
Index: scm/font.scm
diff --git a/scm/font.scm b/scm/font.scm
index  
82f6d489901782ef4038977e2c6350827d9941fe..347dcebc59ce35491a5f8ff3c6038cffcc191ffc  
100644
--- a/scm/font.scm
+++ b/scm/font.scm
@@ -249,6 +249,10 @@ used.  This is used to select the proper design size  
for the text fonts.
 ; "emmentaler", "sans-serif", and "monospace", respectively. All fonts are
 ; still accesible through the usual scheme symbols: 'feta, 'roman, 'sans,  
and
 ; 'typewriter.
+;
+; Note that 'LilyPond Serif', 'LilyPond Sans Serif' and 'Lilypond  
Monospace'
+; are aliases that are defined in mf/lilypond-fonts.conf.in.
+
 (define*-public (set-global-fonts #:key
   (music "emmentaler")
   (brace "emmentaler")