[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Issue 4485: Refactor \partcombine and \autochange iterators (issue 25027
From: |
nine . fierce . ballads |
Subject: |
Issue 4485: Refactor \partcombine and \autochange iterators (issue 250270043 by address@hidden) |
Date: |
Tue, 07 Jul 2015 02:32:19 +0000 |
Reviewers: ,
Description:
Move the \partcombine context state machine from C++ to Scheme and
move the part-specific work into a new Part_combine_part_iterator.
What remains in Part_combine_iterator is multi-measure rest handling.
The part-specific work is now nothing more than changing context at
specified times, which is basically what \autochange does. There are
still some differences, but most of the implementation of both is now
in the common base Change_sequence_iterator.
Please review this at https://codereview.appspot.com/250270043/
Affected files (+295, -304 lines):
M lily/auto-change-iterator.cc
A lily/change-sequence-iterator.cc
A + lily/include/change-sequence-iterator.hh
M lily/part-combine-iterator.cc
A lily/part-combine-part-iterator.cc
M ly/music-functions-init.ly
M scm/autochange.scm
M scm/define-music-display-methods.scm
M scm/define-music-properties.scm
M scm/define-music-types.scm
M scm/part-combiner.scm
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Issue 4485: Refactor \partcombine and \autochange iterators (issue 250270043 by address@hidden),
nine . fierce . ballads <=