Re: Changes.tely updated - 2.19.x up to September 2014 (issue 147860043 by address@hidden)

[pkx166h]

Thanks to those that checked. New patch uploaded


https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode69
Documentation/changes.tely:69: \once \override ChorName.text = #"foo"
On 2014/09/21 09:59:37, dak wrote:
> ChordName.text

> Maybe make this @lilypond?  If you keep it "example", you'll also need
to
> replace { with @{ and } with @}

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode72
Documentation/changes.tely:72: @example
On 2014/09/21 09:59:38, dak wrote:
> More like @end example

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode75
Documentation/changes.tely:75: with @code{DymanicTexts} or
@code{LyricTexts}.
On 2014/09/21 09:59:37, dak wrote:
> I think you want all of those without the final s.  And it's
DynamicText rather
> than DymanicText.

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode102
Documentation/changes.tely:102: fonts other than the default Ementaler.
On 2014/09/21 09:59:38, dak wrote:
> Emmentaler.  I'm not sure this makes sense without example or
reference.

Typo done. I could think to do was link to openlily.org. Not sure if
this is 'bad form' or not as it is not in our Doc as such but it is a
nice enhancement.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode105
Documentation/changes.tely:105: more flxeibility for grob positions.
For example the @q{left} edge of a
On 2014/09/21 10:20:40, marc wrote:
> s/flxeibility/flexibility/

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode106
Documentation/changes.tely:106: grob can now be aligned on the
@q{center} of its parent.
On 2014/09/21 09:59:37, dak wrote:
> Is this properly documented anywhere?  If not, it's a bit hearsay
without
> specifying at least that this goes via parent-alignment-X and
parent-alignment-Y
> (if I remember correctly).

Maybe Marc H can give a simple example I could add here or perhaps give
a more 'technically correct' summary instead?

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode108
Documentation/changes.tely:108: @item Improvements to the
@code{\partial} command have been made to
On 2014/09/21 09:59:37, dak wrote:
> Bar checks are not a "parallel context", but since this is really more
a bug fix
> than anything else, I'd just remove that item rather than haggle over
its
> wording.

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode113
Documentation/changes.tely:113: aligned seperately rather than simply
centered against the clef glyph.
On 2014/09/21 09:59:37, dak wrote:
> "separately", but again I think that's more a bug fix than anything
else.

OK, removed (I really must install that spell check plug-in! to my
editor).

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode118
Documentation/changes.tely:118: @item The @code{NullVoice} context is
now @q[below} @code{Score}.
On 2014/09/21 10:20:40, marc wrote:
> '{' instead of '[' in front of 'below'

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode120
Documentation/changes.tely:120: @item Improvements made to smob
functionality. Basic smob types
On 2014/09/21 09:59:37, dak wrote:
> Internals.  Does not belong into Changes.

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode127
Documentation/changes.tely:127: the existing @code{\keepWithTag} and
@code{removeWithTag} commands.  For
On 2014/09/21 10:00:06, Jean-Charles wrote:
> @code{\keepWithTag} and @code{\removeWithTag}

Done.

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode150
Documentation/changes.tely:150: @code{Rest_collision} grobs now ignore
other grobs that do not use the
On 2014/09/21 09:59:37, dak wrote:
> I think that's again more of a bug fix than anything else.  Basically,
it
> reduces the number of warnings.

> I'd remove it rather than fix the spellings of the grob and interface
names ;)

Done.

https://codereview.appspot.com/147860043/