[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: Appendix - Articulations and Ornamentation - part 2 (issue 1148
From: |
pkx166h |
Subject: |
Re: Doc: Appendix - Articulations and Ornamentation - part 2 (issue 114840043 by address@hidden) |
Date: |
Sun, 20 Jul 2014 12:23:09 +0000 |
Thanks David for the review, I have also edited the commit message.
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1547
Documentation/notation/notation-appendices.itely:1547: @multitable
@columnfractions .20 .20 .20 .20 .20
On 2014/07/16 13:09:55, dak wrote:
No @headitem?
Because I moved everything for each script into a single column it made
having headers redundant.
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1606
Documentation/notation/notation-appendices.itely:1606: @multitable
@columnfractions .20 .20 .20 .20
On 2014/07/16 13:09:55, dak wrote:
Missing the fifth .20 here, no?
I could see my inconsistecy in my last iteration of this patch. Make doc
complained when I used 5 columns but lilypond-book on its own didn't.
However as I have now added a third example for each script
having 5 columns makes it all look too squashed together so I have gone
back to 4 columns.
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1691
Documentation/notation/notation-appendices.itely:1691: @multitable
@columnfractions .20 .20 .20 .20
On 2014/07/16 13:09:55, dak wrote:
Same here?
See above.
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1800
Documentation/notation/notation-appendices.itely:1800: @multitable
@columnfractions .20 .20 .20 .20
On 2014/07/16 13:09:55, dak wrote:
I count only 3 columns now, but that should not be a problem But
wants to be
five eventually?
Again See above.
https://codereview.appspot.com/114840043/