[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Make sure slurs actually avoid stafflines. (issue 15400049)
From: |
hanwenn |
Subject: |
Re: Make sure slurs actually avoid stafflines. (issue 15400049) |
Date: |
Wed, 23 Oct 2013 06:38:59 +0000 |
https://codereview.appspot.com/15400049/diff/1/lily/slur-configuration.cc
File lily/slur-configuration.cc (right):
https://codereview.appspot.com/15400049/diff/1/lily/slur-configuration.cc#newcode121
lily/slur-configuration.cc:121: Real mid_pts_cor = 0.6 * correction / (3
* (t - (t * t)));
this new code looks considerably more heuristic compared to the old one
(it's full of random constants such as 0.6, 0.4, 3, etc.), and will be
much more difficult to make sense of if anybody finds a problem with it
in the future.
Why not fix the problem that Keith pointed out exactly?
https://codereview.appspot.com/15400049/
- Make sure slurs actually avoid stafflines. (issue 15400049), lemzwerg, 2013/10/22
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), tdanielsmusic, 2013/10/22
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), k-ohara5a5a, 2013/10/23
- Re: Make sure slurs actually avoid stafflines. (issue 15400049),
hanwenn <=
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), k-ohara5a5a, 2013/10/23
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), dak, 2013/10/23
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), janek . lilypond, 2013/10/23
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), janek . lilypond, 2013/10/23
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), k-ohara5a5a, 2013/10/23
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), janek . lilypond, 2013/10/24
- Re: Make sure slurs actually avoid stafflines. (issue 15400049), k-ohara5a5a, 2013/10/25