[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Corrects bounding box for longa (Issue 826) (issue 12032043)
From: |
Phil Holmes |
Subject: |
Re: Corrects bounding box for longa (Issue 826) (issue 12032043) |
Date: |
Mon, 29 Jul 2013 21:07:36 +0100 |
----- Original Message -----
From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, July 29, 2013 6:08 PM
Subject: Corrects bounding box for longa (Issue 826) (issue 12032043)
https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf#newcode116
mf/feta-noteheads.mf:116: final_line_length := quanted_line_length *
staff_space;
This is rather hard to figure out. Why don't you make
define_pixels (final_line_length)
and calculate final_line_length# as quanted_line_length * staff_space# ?
The problem is that it is very hard to figure out the relation between
boxtop# and final_line_length.
https://codereview.appspot.com/12032043/
I'm not particularly confident with metafont code, and so generally try to
make the minimum change necessary to effect the desired result. That said, I
think final_line_length is a spurious variable, and so if you think the
relationship between it and the boxxxx variables is not clear, would suggest
deleting that variable.
--
Phil Holmes