lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rewrite Self_alignment_interface (issue 7768043)


From: janek . lilypond
Subject: Re: rewrite Self_alignment_interface (issue 7768043)
Date: Sat, 30 Mar 2013 18:25:23 +0000

On 2013/03/30 18:15:11, MikeSol wrote:
In general, I see a lot of reassigning of parents.  What is the goal
with this
(sorry if you've explained this already)?

What do you mean by "reassigning of parents"?  I fetch grobs' parents
often, but i don't give grobs new parents.


https://codereview.appspot.com/7768043/diff/38001/lily/fingering-engraver.cc#newcode142
lily/fingering-engraver.cc:142:
Self_alignment_interface::aligned_on_x_parent
(fingerings_[i]->self_scm ()));
This needs to be a chained offset procedure.
See chain_offset_callback elsewhere
in the code.

ok, will investigate.


https://codereview.appspot.com/7768043/diff/38001/lily/paper-column.cc#newcode222
lily/paper-column.cc:222: /*
Good work!

Thanks :)

Janek

https://codereview.appspot.com/7768043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]