lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix composition of markup lists containing markup command list calls


From: ianhulin44
Subject: Re: Fix composition of markup lists containing markup command list calls (issue 7799048)
Date: Mon, 25 Mar 2013 11:37:59 +0000

LGTM, apart from comment on the doc-string.

Cheers, Ian


https://codereview.appspot.com/7799048/diff/3001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/7799048/diff/3001/scm/define-markup-commands.scm#newcode4286
scm/define-markup-commands.scm:4286: (let ((key (make-symbol "key")))
I don't understand the last sentence of the doc-string at first reading.
 Is it something like:
"Although the means of getting such results differ, the results
themselves should be comparable"

https://codereview.appspot.com/7799048/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]