Re: Includes empty skylines in minimum translation calculations (issue 7304068)

[dak]

https://codereview.appspot.com/7304068/diff/27001/lily/align-interface.cc
File lily/align-interface.cc (right):

https://codereview.appspot.com/7304068/diff/27001/lily/align-interface.cc#newcode74
lily/align-interface.cc:74: vector<Skyline_pair> *const ret,
Usage of const here is "dear compiler, I promise that ret will not point
to anything else in this function".  Which is usually not very
interesting.  You probably mean that the pointer is not going to be used
for changing the passed vector.  That, however, would rather be
vector<Skyline_pair> const *ret

https://codereview.appspot.com/7304068/diff/27001/lily/align-interface.cc#newcode75
lily/align-interface.cc:75: vector<bool> *const skip_elt)
Same here.  Admittedly, this was wrong before, and you changed the const
association of "elements" probably without much thinking (it was wrong
previously, too), but at any rate this should be fixed.  No need to
restart the countdown for that, but it should get retested to make sure
that the changed "const" qualifier actually is accepted by the compiler.

https://codereview.appspot.com/7304068/