[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Make test-output-distance regtest contain span bars (issue 7400057)
From: |
dak |
Subject: |
Re: Make test-output-distance regtest contain span bars (issue 7400057) |
Date: |
Thu, 28 Feb 2013 05:57:45 +0000 |
Reviewers: lemzwerg, thomasmorley65,
Message:
On 2013/02/28 00:45:57, thomasmorley65 wrote:
LGTM
One suggestion:
https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly
File input/regression/test-output-distance.ly (right):
https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly#newcode20
input/regression/test-output-distance.ly:20:
How about setting \bar "|."
Might be a stronger flag.
I think we have a special span bar at the start, and a default span bar
at the end. \bar "|." would leave us only with special span bars unless
one expands the whole example by another bar. Neither option makes me
really enthused, but I am willing to let myself be convinced.
Description:
Make test-output-distance regtest contain span bars
Since span bars don't turn up in the metrics, the regtests don't show
them. To make catastrophic span bar failures show up at least
somewhere, the ever-changing test-output-distance test is made to
include them.
Please review this at https://codereview.appspot.com/7400057/
Affected files:
M input/regression/test-output-distance.ly
Index: input/regression/test-output-distance.ly
diff --git a/input/regression/test-output-distance.ly
b/input/regression/test-output-distance.ly
index
6ea91213b7c606996dad291486c713fb3eefd0d7..ef10b57f9c629175c4c93db2c5ce05b14dc6924a
100644
--- a/input/regression/test-output-distance.ly
+++ b/input/regression/test-output-distance.ly
@@ -18,5 +18,7 @@ it should always show up in the output-distance testing. "
ragged-right = ##f
}
-\relative c' { c4 d f8_\f[ g-.] }
+\new PianoStaff << \new Staff \relative c' { c4 d f8_\f[ g-.] r4 }
+ \new Staff { \clef "bass" R1 }
+ >>