[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Caches the interior skylines of vertical axis groups and systems. (i
From: |
dak |
Subject: |
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044) |
Date: |
Sat, 23 Feb 2013 18:07:54 +0000 |
https://codereview.appspot.com/7185044/diff/45018/input/regression/tuplet-bracket-outside-staff-priority.ly
File input/regression/tuplet-bracket-outside-staff-priority.ly (right):
https://codereview.appspot.com/7185044/diff/45018/input/regression/tuplet-bracket-outside-staff-priority.ly#newcode17
input/regression/tuplet-bracket-outside-staff-priority.ly:17:
\tupletOutsideStaffPriority #1
Why a changed regtest when purportedly, according to the changes entry,
the functionality should not be changed?
https://codereview.appspot.com/7185044/diff/45018/input/regression/tuplet-number-outside-staff-positioning.ly
File input/regression/tuplet-number-outside-staff-positioning.ly
(right):
https://codereview.appspot.com/7185044/diff/45018/input/regression/tuplet-number-outside-staff-positioning.ly#newcode14
input/regression/tuplet-number-outside-staff-positioning.ly:14:
\tupletOutsideStaffPriority #1
Same here.
https://codereview.appspot.com/7185044/diff/45018/input/regression/tuplet-number-outside-staff-priority.ly
File input/regression/tuplet-number-outside-staff-priority.ly (right):
https://codereview.appspot.com/7185044/diff/45018/input/regression/tuplet-number-outside-staff-priority.ly#newcode12
input/regression/tuplet-number-outside-staff-priority.ly:12:
\tupletOutsideStaffPriority #1
same here.
https://codereview.appspot.com/7185044/diff/45018/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/7185044/diff/45018/ly/music-functions-init.ly#newcode1376
ly/music-functions-init.ly:1376: tupletOutsideStaffPriority =
Does that mean that the statement in changes.tely about tuplets'
reaction to outside-staff-priority being the same as before is false?
This kind of function does not make any sense. For one thing, it does
not serve a high level function but manipulates a single low-level
parameter. Providing a music function for this kind of numerical
manipulation is decidedly weird. For another, it only provides an
override method while this parameter will often be in need of tweaking.
https://codereview.appspot.com/7185044/
- Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), (continued)
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), dak, 2013/02/19
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), dak, 2013/02/23
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044),
dak <=
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), tdanielsmusic, 2013/02/23
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), k-ohara5a5a, 2013/02/24
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), dak, 2013/02/24
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), dak, 2013/02/24
Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044), dak, 2013/02/25