[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 754: don't transpose generic property-setting music commands (
From: |
k-ohara5a5a |
Subject: |
Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057) |
Date: |
Fri, 08 Feb 2013 04:46:27 +0000 |
Yesterday's patch was better.
The 'untransposable property is more closely related to the source of
the events (\transposition or \instrumentSwitch) than to the event type
(override or propertySet).
https://codereview.appspot.com/7303057/diff/2001/scm/define-music-types.scm
File scm/define-music-types.scm (right):
https://codereview.appspot.com/7303057/diff/2001/scm/define-music-types.scm#newcode379
scm/define-music-types.scm:379: (untransposable . #t)
Well, not every Grob property that is a pitch is untransposable. The
second pitch in a pitchedTrill, for example, should be transposed along
with the first pitch.
Do we need to remember to avoid \override on those that are
transposable?
https://codereview.appspot.com/7303057/diff/2001/scm/define-music-types.scm#newcode446
scm/define-music-types.scm:446: (untransposable . #t)
Not every context property that is a pitch is untransposable. The tonic
of the Staff, for example.
https://codereview.appspot.com/7303057/
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057),
k-ohara5a5a <=
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), dak, 2013/02/08
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), dak, 2013/02/08
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), dak, 2013/02/09
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), k-ohara5a5a, 2013/02/11
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), dak, 2013/02/11
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), dak, 2013/02/11
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), k-ohara5a5a, 2013/02/11
- Re: Issue 754: don't transpose generic property-setting music commands (issue 7303057), dak, 2013/02/11