lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Various clean-ups in stems and beams. (issue 6584045)


From: aleksandr . andreev
Subject: Re: Various clean-ups in stems and beams. (issue 6584045)
Date: Sun, 04 Nov 2012 22:40:50 +0000


http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly
File input/regression/kievan-notation.ly (right):

http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly#newcode12
input/regression/kievan-notation.ly:12: c4 c4 c8 [ d8 ] c4 c2 b,\longa
We should add an unbeamed eighth note to the regtest, since its correct
appearance is now controlled by

note-head::calc-kievan-duration-log

Maybe something like

c4 c8 c8[ d8] c4 c2 b,\longa

http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly
File input/regression/note-head-style.ly (right):

http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108
input/regression/note-head-style.ly:108: \override Staff.Dots.style =
#'kievan
Why can't we use the new function here, e.g.,

\kievanOn

http://codereview.appspot.com/6584045/diff/13014/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/6584045/diff/13014/ly/engraver-init.ly#newcode1150
ly/engraver-init.ly:1150: \override Stem.length = #0.0
It seems like we also need something like:

\override Flag.stencil = ##f

Otherwise "flags" appear on Kievan eighth notes.

http://codereview.appspot.com/6584045/diff/13014/ly/property-init.ly
File ly/property-init.ly (right):

http://codereview.appspot.com/6584045/diff/13014/ly/property-init.ly#newcode310
ly/property-init.ly:310: \override Stem.length = #0.0
Also need here:

\override Flag.stencil = ##f

http://codereview.appspot.com/6584045/diff/13014/ly/property-init.ly#newcode323
ly/property-init.ly:323: \revert Stem.length
And here:

\revert Flag.stencil

http://codereview.appspot.com/6584045/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]