[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allows lyrics to slide under TimeSignature when OctaveEight present.
From: |
dak |
Subject: |
Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068) |
Date: |
Fri, 11 May 2012 07:09:04 +0000 |
http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc
File lily/pure-from-neighbor-engraver.cc (right):
http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56
lily/pure-from-neighbor-engraver.cc:56: in_same_column (Grob *g1, Grob
*g2)
On 2012/05/11 05:23:27, MikeSol wrote:
On 2012/05/10 21:40:48, janek wrote:
> That's problably the most stupid question ever, but why this doesn't
it begin
> with Pure_from_neighbor_engraver:: ? I don't see it being special.
It doesn't need to be a class method - it'll never be called outside
of this
file. It is just a small helper function.
Then it should be declared static, right?
http://codereview.appspot.com/6201068/