lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713


From: janek . lilypond
Subject: Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)
Date: Fri, 11 May 2012 00:21:54 +0000


http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc
File lily/note-collision.cc (right):

http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc#newcode301
lily/note-collision.cc:301: of the note heads on the sides that
interfere. */
So, should the offsets really be multiplied?  I'd rather think not.

http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc#newcode303
lily/note-collision.cc:303: shift_amount *= (extent_up[RIGHT] -
extent_down[LEFT]) / extent_down.length ();
The interesting thing is that the order of voices matters:

<<
  \override Staff.NoteHead #'style = #'altdefault
  { c''\breve*1/2 b'1 }
  \\
  { b'1 c''\breve*1/2 }


the placement of the notes should be the same in both measures, but it
isn't.  Moreover, it's the opposite of current master.

http://codereview.appspot.com/6189048/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]