[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: Learning: Use voices in the intended order. (issue 5507050)
From: |
k-ohara5a5a |
Subject: |
Re: Doc: Learning: Use voices in the intended order. (issue 5507050) |
Date: |
Tue, 13 Mar 2012 05:53:39 +0000 |
Reviewers: carl.d.sorensen_gmail.com, Graham Percival, Trevor Daniels,
Message:
On 2012/03/10 12:36:05, Trevor Daniels wrote:
I could see no reason for this patch causing problems
I had mis-spelled the option to ignore-collisions, which threw a
warning, but I didn't catch it because other overrides made the
ignore-collisions setting (which you removed) redundant, so the output
looked fine.
Thanks for running a make-doc and pushing.
http://codereview.appspot.com/5507050/diff/13004/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
http://codereview.appspot.com/5507050/diff/13004/Documentation/learning/fundamental.itely#newcode805
Documentation/learning/fundamental.itely:805: \once \override NoteColumn
#'ignore-collision = ##t
The line above can be removed, because in the pushed patch it is removed
in the version in Ch 4.
http://codereview.appspot.com/5507050/diff/13004/Documentation/learning/fundamental.itely#newcode855
Documentation/learning/fundamental.itely:855: \once \override NoteColumn
#'ignore-collision = ##t
Line above can be removed
Description:
Doc: Learning: Use voices in the intended order.
Doc: Notation: Mention how hideNotes hides beams.
Please review this at http://codereview.appspot.com/5507050/
Affected files:
M Documentation/learning/fundamental.itely
M Documentation/learning/tweaks.itely
M Documentation/notation/editorial.itely