[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Various updates to reduce make doc output (issue 5727055)
From: |
Julien Rioux |
Subject: |
Re: Various updates to reduce make doc output (issue 5727055) |
Date: |
Sun, 4 Mar 2012 13:05:07 -0500 |
On Sun, Mar 4, 2012 at 12:04 PM, Phil Holmes <address@hidden> wrote:
> ----- Original Message ----- From: <address@hidden>
>> http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile#newcode283
>> Documentation/GNUmakefile:283: cd $(outdir) &&
>> $(buildscript-dir)/run-and-check "$(LILYPOND_BINARY) --verbose
>> $(top-src-dir)/ly/generate-documentation" "$(*F).log"
>> Why not just call it "generate-documentation.log"
>
>
> I did think of that, too! It actually produces internals.log, and I thought
> that might fit better with the target. I used the make variable to be
> relatively consistent with the other invocations.
>
Since this is a very specific rule and not a catch-all, there is no
benefit in using the make variable. The filename also clashes with
internals.log produced by pdflatex. That's why I think something else
would be better.
Cheers,
Julien
- Various updates to reduce make doc output (issue 5727055), PhilEHolmes, 2012/03/04
- Re: Various updates to reduce make doc output (issue 5727055), julien . rioux, 2012/03/04
- Re: Various updates to reduce make doc output (issue 5727055), graham, 2012/03/04
- Re: Various updates to reduce make doc output (issue 5727055), PhilEHolmes, 2012/03/11
- Re: Various updates to reduce make doc output (issue 5727055), PhilEHolmes, 2012/03/12
- Re: Various updates to reduce make doc output (issue 5727055), julien . rioux, 2012/03/12
- Re: Various updates to reduce make doc output (issue 5727055), Phil Holmes, 2012/03/12
- Re: Various updates to reduce make doc output (issue 5727055), Graham Percival, 2012/03/12
- Re: Various updates to reduce make doc output (issue 5727055), Phil Holmes, 2012/03/12
- Re: Various updates to reduce make doc output (issue 5727055), Julien Rioux, 2012/03/13
- Re: Various updates to reduce make doc output (issue 5727055), Phil Holmes, 2012/03/14
- Re: Various updates to reduce make doc output (issue 5727055), Julien Rioux, 2012/03/14