Re: Segfault 2.15.23 Span_bar_stub_engraver

[David Kastrup]

"address@hidden" <address@hidden> writes:

> On Jan 5, 2012, at 11:24 AM, David Kastrup wrote:
>
>> address@hidden writes:
>> 
>>> On Jan 5, 2012, at 7:51 AM, David Kastrup wrote:
>>> 
>>>> Grob::get_vertical_axis_group is not protected against the case where g
>>>> has an axis group interface but no Y_AXIs parent.
>>> 
>>> I thought it was.  If g has no Y_AXIS parent, then when
>>> get_vertical_axis_group (g->get_parent (Y_AXIS)); is called, the first
>>> test if (!g) will return 0, no?
>> 
>> Grob::get_vertical_axis_group (Grob *g)
>> {
>> if (!g)
>>   return 0;
>> if (Axis_group_interface::has_interface (g)
>>     && Align_interface::has_interface (g->get_parent (Y_AXIS)))
>>   return g;
>> return get_vertical_axis_group (g->get_parent (Y_AXIS));
>> 
>> }
>> 
>> You call Align_interface::has_interface (g->get_parent (Y_AXIS)) here
>> before you call get_vertical_axis_group.
>> 
>
> Fixed.

Note: I have no clue about what the code does.  This was just one thing
that did not earn extra credit in the "obviously not wrong" category
with me.  I don't have more to go by at the moment.  And it is scary to
me if that may, at times, be enough.

-- 
David Kastrup