Re: Patches NSIS (issue 5498107)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Wednesday, January 04, 2012 7:00 PM
Subject: Patches NSIS (issue 5498107)


> Overall, I think it wiser to avoid touching the windows path, *but* this
> concept has been reported to resolve the problem.
>
> http://nsis.sourceforge.net/Special_Builds
> If you can run GUB, can you try putting the changed parameter on the
> scons command line, rather than patching the default parameters.
> Changes in the upstream nsis could easily cause the patch no not apply.
>
>
> http://codereview.appspot.com/5498107/diff/1/gub/specs/nsis.py
> File gub/specs/nsis.py (right):
>
> http://codereview.appspot.com/5498107/diff/1/gub/specs/nsis.py#newcode14
> gub/specs/nsis.py:14: scons_flags = misc.join_lines ('''
> NSIS_MAX_STRLEN=8192
>
> http://codereview.appspot.com/5498107/


I think this is highly likely to be the problem.  Yesterday I tried putting 
long strings into Windows registry, and got to over 70k characters before I 
got bored. I concluded that it wasn't a problem with the length of strings 
in the registry and therefore less likely to be a "feature" of windows PATH. 
I assume that what happens is the path gets close to the NSIS string size 
limit, is read, appended to, and thus truncated, and is then written back to 
the registry.

If someone with GUB capability can create a test patch, I'd be happy to try 
it out (tho' not tomorrow - working).

--
Phil Holmes