lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Updates makelsr to point to lilypond exe (issue 5489134)


From: PhilEHolmes
Subject: Updates makelsr to point to lilypond exe (issue 5489134)
Date: Mon, 02 Jan 2012 12:37:13 +0000

Reviewers: percivall,

Message:
Please review

Description:
The CG discussing makelsr says "Make sure that convert-ly and lilypond
commands in current PATH are in a bleeding edge version" but in practice
the it constructs a path to convert-ly, but not to the lilypond exe.
The only indication that lilypond isn't found is a cryptic "sh:
lilypond: not found" in the middle of reams of output.  This update uses
the same path to lilypond as to convert-ly which avoids the need for a
correct PATH statement.  The exe is used to check that the files being
converted are real lilypond ones and not some unsafe command.

If this patch is accepted, I'll update the CG with details.

Please review this at http://codereview.appspot.com/5489134/

Affected files:
  M scripts/auxiliar/makelsr.py


Index: scripts/auxiliar/makelsr.py
diff --git a/scripts/auxiliar/makelsr.py b/scripts/auxiliar/makelsr.py
index 8b4f3a3e320a6aedbbe6df31c581fcfe36c33b00..7bbd3399c4f8c3f60da6e019e4ae947cd6ba320f 100755
--- a/scripts/auxiliar/makelsr.py
+++ b/scripts/auxiliar/makelsr.py
@@ -73,6 +73,8 @@ elif os.path.isfile("build/out/bin/convert-ly"):
 else:
     conv_path=''
 convert_ly=conv_path+'convert-ly'
+lilypondexe=conv_path+'lilypond'
+
 print 'using '+convert_ly

 unsafe = []
@@ -179,7 +181,7 @@ def copy_ly (srcdir, name, tags):
     # no need to check snippets from input/new
     if in_dir and in_dir in srcdir:
         # -V seems to make unsafe snippets fail nicer/sooner
- e = os.system ("lilypond -V -dno-print-pages -dsafe -o /tmp/lsrtest '%s'" % dest) + e = os.system (lilypondexe + " -dno-print-pages -dsafe -o /tmp/lsrtest " + dest)
         if e:
             unsafe.append (dest)






reply via email to

[Prev in Thread] Current Thread [Next in Thread]