Re: Move note names to scm (issue3247041)

[n . puttock]

Hi Valentin,

Here are a few nitpicks (some of which I couldn't comment on directly):

All the language files have a rogue newline at the end.

The indentation inside language-pitch-names is artificially compressed,
e.g.,

(bad)

    (nederlands . (
      (ceses . ,(ly:make-pitch -1 0 DOUBLE-FLAT))

(good)

    (nederlands . (
                   (ceses . ,(ly:make-pitch -1 0 DOUBLE-FLAT))

note-names-language needs some minor reindenting.

Cheers,
Neil


http://codereview.appspot.com/3247041/diff/19001/ly/predefined-guitar-fretboards.ly
File ly/predefined-guitar-fretboards.ly (right):

http://codereview.appspot.com/3247041/diff/19001/ly/predefined-guitar-fretboards.ly#newcode456
ly/predefined-guitar-fretboards.ly:456: #(ly:parser-set-note-names
parser pitchnames)
need newline

http://codereview.appspot.com/3247041/