Re: Move note names to scm (issue3247041)

[Carl . D . Sorensen]

I couldn't comment on the last two files in the patch set.

Here are some comments on the other files.

Thanks,

Carl



http://codereview.appspot.com/3247041/diff/9001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/3247041/diff/9001/ly/music-functions-init.ly#newcode365
ly/music-functions-init.ly:365: (_i "Music-function wrapper for
selecting note names language.")
I prefer the old doc string to the new doc string.  Actually, I would
prefer it to say "Set note names for language @var{str}."  And I would
prefer the name of the argument to be "lang" or "note-language" instead
of "str", because "str" indicates the type of the variable, not the
purpose of the variable.

http://codereview.appspot.com/3247041/diff/9001/ly/predefined-guitar-fretboards.ly
File ly/predefined-guitar-fretboards.ly (right):

http://codereview.appspot.com/3247041/diff/9001/ly/predefined-guitar-fretboards.ly#newcode456
ly/predefined-guitar-fretboards.ly:456: #(ly:parser-set-note-names
parser pitchnames)
Why is this call different from the call in line 20?  It seems to me
that it should be the same.

http://codereview.appspot.com/3247041/