[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: manual convert-ly: minimum-Y-extent (1298+1299). (issue3212041)
From: |
pnorcks |
Subject: |
Re: manual convert-ly: minimum-Y-extent (1298+1299). (issue3212041) |
Date: |
Fri, 19 Nov 2010 07:41:51 +0000 |
Thanks for your work, Keith.
I tested all of the changed snippets, and I didn't detect any noticeable
differences (besides some spacing improvements).
One question about the commit message: it mentions
"engravers-one-by-one.ly", but there are no changes to this file in your
patch. Should there be changes?
Otherwise, looks good to me.
Thanks,
Patrick
http://codereview.appspot.com/3212041/