[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: T1249 - Remove (define define-ly-syntax define-public). (issue231304
|
From: |
Ian Hulin |
|
Subject: |
Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044) |
|
Date: |
Wed, 10 Nov 2010 20:11:37 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b3pre Thunderbird/3.1.6 |
Hi Patrick,
On 10/11/10 06:01, address@hidden wrote:
> Hi Ian,
>
> LGTM.
>
> Before sending me the git patch, I would recommend changing the subject
> from "Remove (define define-ly-syntax define-public)" to something more
> accurate that reflects what this patch fixes.
>
> Thanks for your work on this!
>
> Regards,
> Patrick
>
> http://codereview.appspot.com/2313044/
Patch with amended title attached.
Ian
0001-T1249-Prevent-compilation-error-in-ly-syntax-constru.patch
Description: Text Data
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), v . villenave, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/05
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/10
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044),
Ian Hulin <=